atom feed19 messages in org.perl.perl5-portersRe: [perl #72704] Buggy fputs(f,s) vs...
FromSent OnAttachments
kmx via RTMar 3, 2010 1:47 am 
Steve HayMar 4, 2010 8:40 am 
Dave MitchellMar 4, 2010 12:17 pm 
Steve HayMar 4, 2010 4:17 pm 
Jan DuboisMar 4, 2010 6:53 pm 
Jan DuboisMar 4, 2010 7:07 pm 
kmx via RTMar 4, 2010 11:15 pm 
Jan DuboisMar 5, 2010 12:26 am 
Steve HayMar 5, 2010 1:18 am 
Jan DuboisMar 5, 2010 12:50 pm 
kmxMar 5, 2010 11:52 pm 
Tim BunceMar 6, 2010 1:37 pm 
kmx via RTApr 11, 2010 2:35 am 
Jan Dubois via RTApr 21, 2010 11:55 pm 
kmx via RTApr 22, 2010 10:46 am 
kmx via RTMay 5, 2010 4:30 am 
Jan DuboisMay 5, 2010 12:26 pm 
Tim BunceMay 6, 2010 4:05 am 
Craig A. BerryMay 6, 2010 6:21 am 
Subject:Re: [perl #72704] Buggy fputs(f,s) vs. fputs(s,f) on Win32 (maybe not only)
From:Tim Bunce (Tim.@pobox.com)
Date:May 6, 2010 4:05:31 am
List:org.perl.perl5-porters

On Wed, May 05, 2010 at 12:27:02PM -0700, Jan Dubois wrote:

On Wed, 05 May 2010, kmx via RT wrote:

I see comming deadline for 5.12.1.

Could somebody competent consider including 634b482c + 20c8f8f to 5.12.1

634b482c is already in maint-5.12 as 72c7417:

http://perl5.git.perl.org/perl.git/commitdiff/72c7417

20c8f8f has been requested (by me) and got a second vote from Vincent. It requires one other person with commit access to vote for it to be eligible for merging.

Given that this bug was detected with Devel::NYTProf, maybe Tim is willing to put his vote in for this one (it is a single line addition to XSUB.h).

It certainly gets a nod from me. (Strictly speaking I don't have a vote as I never did sort out commit rights to the new repository.)

Tim.

Cheers, -Jan

commit 20c8f8f9118fd23081c818637815bf1aab60b808 Author: Jan Dubois <ja@activestate.com> Date: Wed Apr 21 16:49:09 2010 -0700

XSUB.h is supposed to redefine fgets under PERL_IMPLICIT_SYS, but doesn't.

See also http://rt.cpan.org/Public/Bug/Display.html?id=55049 with workaround in
http://code.google.com/p/perl-devel-nytprof/source/detail?r=1168

diff --git a/XSUB.h b/XSUB.h index f23df37..06cb1c3 100644 --- a/XSUB.h +++ b/XSUB.h @@ -507,6 +507,7 @@ Rethrows a previously caught exception. See
L<perlguts/"Exception # define ferror PerlSIO_ferror # define clearerr PerlSIO_clearerr # define getc PerlSIO_getc +# define fgets PerlSIO_fgets # define fputc PerlSIO_fputc # define fputs PerlSIO_fputs # define fflush PerlSIO_fflush